Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!(core): add new variants to OrbitPolicy #238

Merged
merged 5 commits into from
Dec 3, 2024
Merged

Conversation

imrn99
Copy link
Collaborator

@imrn99 imrn99 commented Nov 25, 2024

Description

Associated issue: closes #235

Content description:

  • add two new variants OrbitPolicy::VertexLinear & OrbitPolicy::FaceLinear
  • handle their computation in Orbit2
  • change OrbitPolicy::Face to use the beta 0 & beta 1 functions (it previously only used beta 1, which is what OrbitPolicy::FaceLinear does now)

Additional information

  • Breaking change

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 81.01266% with 15 lines in your changes missing coverage. Please review.

Project coverage is 79.30%. Comparing base (a924645) to head (7de7dcc).

Files with missing lines Patch % Lines
honeycomb-core/src/attributes/manager.rs 16.66% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
+ Coverage   79.21%   79.30%   +0.09%     
==========================================
  Files          52       52              
  Lines        6953     7008      +55     
==========================================
+ Hits         5508     5558      +50     
- Misses       1445     1450       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@imrn99 imrn99 marked this pull request as ready for review November 25, 2024 09:46
Copy link
Member

@cedricchevalier19 cedricchevalier19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the use case for the new policies?

@imrn99
Copy link
Collaborator Author

imrn99 commented Dec 3, 2024

What is the use case for the new policies?

Taking faces as an example:

  • FaceLinear: If I need to compute a value from a face's edges, I'll try to build a sliding window iterator over an (ordered) list of its vertices.
  • Face: If I'm searching for a vertex to star a polygon from, I probably want to search in both direction for efficiency. see very rough drawing below, though here it's an obvious edge case it's a bad example, here's another: IIRC 3-sew involves traversal of the faces in opposite directions, using both beta functions

@imrn99 imrn99 merged commit 85e0df0 into master Dec 3, 2024
13 checks passed
@imrn99 imrn99 deleted the more-orbit-policies branch December 3, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement]: add more OrbitPolicy variants
3 participants